Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when ORCID Exporter not called by user #84

Open
drn05r opened this issue Apr 17, 2024 · 0 comments
Open

Errors when ORCID Exporter not called by user #84

drn05r opened this issue Apr 17, 2024 · 0 comments
Assignees
Labels

Comments

@drn05r
Copy link
Contributor

drn05r commented Apr 17, 2024

Event::DataCiteEvent::datacite_doi from the DataCiteDoi plugin appears to call the ORCID::Exporter and generates the following error messages:

Use of uninitialized value in numeric gt (>) at /opt/eprints3/lib/plugins/EPrints/ORCID/Exporter.pm line 444.

[urn:uuid:008637e0-a9b1-49e4-8f2d-6021c93b2baf] Event::DataCiteEvent::datacite_doi: Error during execution: Can't call method "get_value" on an undefined value at /opt/eprints3/lib/plugins/EPrints/ORCID/Exporter.pm line 458.

I believe that based on the current codebase these are the following lines:


$db->save_user_message( $current_user->get_value( "userid" ),

I purpose that for the first issue and the other checks to see whether other indexes in the $results hashref are set should be updated to check they are defined before checking their value. For the second issue just returning immediately if $current_user is not set. In theory this second change negates the specific need for the first change but I think this may still be a good sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants