Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more generic EpsilonModule, now in ccore #190

Merged
merged 4 commits into from
Feb 12, 2024
Merged

A more generic EpsilonModule, now in ccore #190

merged 4 commits into from
Feb 12, 2024

Conversation

tkchouaki
Copy link
Collaborator

This PR includes some developments related to the Epsilon utility estimators:

The EpsilonModule now does not require to hardcode the names of all epsilon estimators. It loops through the estimator names of your Eqasim config and binds the ones starting with the prefix epsilon_ and binds them. And now that the EpsilonModule is added by default, your usual run scripts will support Epsilon utility estimators by default. You just need to add the prefixe epsilon_ to your usual utility estimator.
e.g:

<parameterset type="estimator" >
	<param name="estimator" value="epsilon_PtUtilityEstimator" />
	<param name="mode" value="pt" />
</parameterset>

This PR also includes an AdaptConfigForEpsilon script in the org.eqasim.core.simulation.mode_choice.epsilon package. that can be used to quickly adjust your config file to use Epsilon utility estimators (while switching to a MaximumUtilitySelector).

@tkchouaki tkchouaki requested a review from sebhoerl February 5, 2024 21:46
@tkchouaki tkchouaki merged commit ffadf34 into develop Feb 12, 2024
1 check passed
@tkchouaki tkchouaki deleted the epsilon branch February 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants