Don't replace tx client IPs with the unspecified one #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tusk consensus
Remove most sui crates
Currently we are trying to use the header batches threshold to determine the speed of generating headers, which depends on the rate of batch creations, which in turn depends on the write rate. Instead, adding a new `min_header_delay` parameter, which allows proposing headers before reaching batch threshold, would make the header propose latency more predictable especially under lower TPS. For now, the `min_header_delay` is set to 1.8s, only slightly below `max_header_delay`, to separate behavior change from this PR. We will run experiments on different values. One possibility as @arun-koshy proposed is to set `min_header_delay` to 1s and `max_header_delay` to 5s. Also, ensure leader only needs to wait for parent stakes and nothing else.
Cherry-pick Narwhal upstream changes
Remove web apps
remove ws hack
Remove mysten-metrics
Dependency cleanup
feat: add GC test
chore: remove narwhal/Docker narwhal/scripts narwhal/examples and scr…
Signed-off-by: ljedrz <ljedrz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the worker transaction clients have their IPs replaced with the unspecified one (
0.0.0.0), which is undesirable. This PR removes it.