fix: abort on panic in tokio thread #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeapoz
reviewed
Jul 25, 2024
| @@ -7,6 +7,9 @@ edition = "2021" | |||
| [workspace] | |||
| members = ["state-reconstruct-fetcher", "state-reconstruct-storage"] | |||
|
|
|||
| [profile.release] | |||
| panic = 'abort' | |||
There was a problem hiding this comment.
I'm not sure if this should be the default behaviour. When possible, I think each task should run to completion to make sure that the state won't get corrupted. For tasks that may panic I'd prefer to handle the error.
There was a problem hiding this comment.
I totally agree the threads shouldn't panic - if there is code that panics on invalid network data, disk failure or whatever we should fix that. But I don't know where the code might be; #104 happened just once - it could be some irreproducible cosmic ray... This change is just to find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #104 .