feat: map l1 batch numbers to their l1 block number equivalent #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeapoz
force-pushed
the
feat/l1-batch-mapper
branch
from
06885c4
to
9e30635
Compare
vbar
reviewed
Aug 6, 2024
src/processor/snapshot/exporter.rs
Outdated
| @@ -108,17 +111,17 @@ impl SnapshotExporter { | |||
| .database | |||
| .iterator_cf(index_to_key_map, rocksdb::IteratorMode::Start); | |||
|
|
|||
| let chunk_size = num_logs / num_chunks as u64; | |||
| let num_chunks = (num_logs / SNAPSHOT_CHUNK_SIZE as u64) + 1; | |||
There was a problem hiding this comment.
won't that produce an empty last chunk, when num_logs is exactly divisible by SNAPSHOT_CHUNK_SIZE?
There was a problem hiding this comment.
OK, but that println! probably shouldn't have stayed...
vbar
reviewed
Aug 7, 2024
| @@ -232,13 +222,14 @@ impl L1Fetcher { | |||
| let tx_handle = self.spawn_tx_handler( | |||
| hash_rx, | |||
| calldata_tx, | |||
| token.clone(), | |||
| self.cancellation_token.clone(), | |||
There was a problem hiding this comment.
This is odd; if the cancellation token is included in L1Fetcher, it doesn't have to be passed separately - no?
vbar
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_chunksargument. We now use the default chunk size of1_000_000to calculate how many chunks we need instead.