- minor fix to globalloop unit identifier

equinor · Oct 13, 2023 · f797a3a · f797a3a
1 parent 8a5318d
commit f797a3a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Dynamic/Identification/ClosedLoopGainGlobalSearchResults.cs b/Dynamic/Identification/ClosedLoopGainGlobalSearchResults.cs
@@ -134,7 +134,7 @@ double[] Scale(double[] v_in)
 
             if (v1_Strength == 0 && v2_Strength == 0 && v3_Strength == 0)
             {
-                // defaultModel.modelParameters.AddWarning(UnitdentWarnings.ClosedLoopEst_GlobalSearchFailedToFindLocalMinima);
+                //defaultModel.modelParameters.AddWarning(UnitdentWarnings.ClosedLoopEst_GlobalSearchFailedToFindLocalMinima);
                 return new Tuple<UnitModel, bool>(null, false);
             }
             double[] objFun = v1;

diff --git a/Dynamic/Identification/ClosedLoopUnitIdentifier.cs b/Dynamic/Identification/ClosedLoopUnitIdentifier.cs
@@ -150,7 +150,7 @@ public class ClosedLoopUnitIdentifier
                     // in some cases the first linear regression done without any estimate of the disutrbance can even have the wrong
                     // sign of the linear gains, although the amplitude will in general be of the right order, thus 
                     // min_gain = -max_gain;  is a more robust choice than some small same-sign value or 0.
-                    var max_gain =  pidProcessInputInitalGainEstimate * initalGuessFactor_higherbound;
+                    var max_gain =  Math.Abs(pidProcessInputInitalGainEstimate * initalGuessFactor_higherbound);
                     var min_gain = - max_gain;
 
                     // when debugging, it might be advantageous to set min_gain equal to the known true value

diff --git a/TimeSeriesAnalysis.Tests/Tests/FindDisturbanceAndModelSimultanouslyTester_MISO.cs b/TimeSeriesAnalysis.Tests/Tests/FindDisturbanceAndModelSimultanouslyTester_MISO.cs
@@ -115,7 +115,7 @@ public void StaticMISO_SetpointChanges_no_disturbance_detectsProcessOk(int pidIn
                 doNegative, true,yset, pidInputIdx);
         }
 
-        [TestCase(0, false,false)] 
+        [TestCase(0, false,false), NonParallelizable] 
         [TestCase(1, false,false)]
         [TestCase(0, false, true),Category("NotWorking_AcceptanceTest")] 
         [TestCase(1, false, true),Category("NotWorking_AcceptanceTest")]