feat: update qc test schema #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
simentha
approved these changes
Jan 14, 2025
iamsegl
pushed a commit
that referenced
this pull request
Jan 14, 2025
🤖 I have created a release *beep* *boop* --- ## [1.8.0](v1.7.0...v1.8.0) (2025-01-14) ### Features * update qc test schema ([#42](#42)) ([ec6670c](ec6670c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
test_nametolong_namesince this is what it’s called in themetoceanpackage, and is in-line withlong_namefield forParameters.It also renames
default_parameterstodefault_variables to avoid confusions with the atmosParametersIt also adds new types to the
default_variablesto accommodate the different types required by the q -tests in themetoceanpackageIt also changes the
List[QCTest]toDict[str, QCTest]in theParameterConfig schema, so that the tests associated with aParametercan be searched by id. This will be useful in future apis which need to modify and delete qc-tests from aparameterinstance.