-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spacing tokens #2575
Comments
Since we’re using a hard grid in EDS 2.0, that means that to achieve an optical vertical margin of 16px for example, we sometimes have to use odd numbers like 9 or 11 depending on the line-height and font-size of the text. To make this easier to work with, my initial idea was to use compound tokens with every possible combination of horisontal and vertical padding value, as well as variants that ensure that the baseline is snapped to the nearest grid line and vertically centered text. After generating sets for tight, compressed, comfortable and relaxed line-heights, I ended up with roughly 24.000 lines of tokens 😁 So that obviously won’t work. Back to the drawing board. |
Revisiting after the Behind the System presentation from Tokens Studio last week. In the presentation Eric Singhartinger mentions an article by Nathan Curtis where he uses the following terminology:
|
In order to can join into this task I broke it into the following items. Im currently working in the "Typography" item: Research: compared how 6 different design system are measuring their spacing and naming it.
Naming: after figure it out typography guidelines we will be able to name tokens. |
Update: We’re waiting for feedback from Figma about an estimated time of delivery for typography variables |
This task is in Todo while we work on the Typography component |
Create spacing tokens in core tokens set
The text was updated successfully, but these errors were encountered: