Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initiate and initialize state to a transition #687

Open
andchiind opened this issue Dec 19, 2024 · 0 comments · May be fixed by #689
Open

Move initiate and initialize state to a transition #687

andchiind opened this issue Dec 19, 2024 · 0 comments · May be fixed by #689
Assignees
Labels
improvement Improvement to existing functionality refactor Refactoring of old functionality

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
We currently have an initiate state since we want to check that we can successfully start a mission before moving to monitor. Using conditional transitions, this check can be done in the transition between idle and monitor, removing the need for the inbetween states. This will move us towards the goal of not doing state changes inside states themselves, so that states merely receive events and the transitions perform the changes themselves.

How will this change existing functionality?
It will simplify the state machine architecture.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added improvement Improvement to existing functionality refactor Refactoring of old functionality labels Dec 19, 2024
@andchiind andchiind self-assigned this Jan 2, 2025
@andchiind andchiind linked a pull request Jan 3, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality refactor Refactoring of old functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant