Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use payloads for mqtt messages #681

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Use payloads for mqtt messages #681

merged 1 commit into from
Dec 20, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 12, 2024

No description provided.

@Eddasol Eddasol added the refactor Refactoring of old functionality label Dec 12, 2024
@Eddasol Eddasol self-assigned this Dec 12, 2024
@Eddasol Eddasol marked this pull request as ready for review December 12, 2024 17:13
@sondreo sondreo self-requested a review December 20, 2024 09:12
sondreo
sondreo approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Has been tested locally.

See a minor non-blocking comment.

src/robot_interface/telemetry/payloads.py Show resolved Hide resolved
@Eddasol Eddasol merged commit 13e53d3 into equinor:main Dec 20, 2024
7 checks passed
@Eddasol Eddasol deleted the payloads branch December 20, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreo sondreo sondreo approved these changes

Assignees

@Eddasol Eddasol

Labels
refactor Refactoring of old functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @sondreo