Upgrade realization filtering #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look into new implementation, and sub-components etc.
Add possibility to select parameter values and create subset of valid realization numbers for the intersection of selections
Component for visualizing and selecting realization numbers.
- Remove unused AddItemButton component - Add some svg icons for SmartNodeSelector
- Add compact visualization - Improve UX
Use circle divs row by row, as discussed in standup
Replace dynamic value with hard coded px values compact vs non-compact visualization
Start: Move filter state logic to parent component for "save all"/"discard all" functionality
Handle states for initial picker tags and smart node selector tags for correct visualization, when previous internal states are moved out to parent component
- When active: Hidden vs conditional rendering to preserve states - When not active, do not render filter details (will reset invalid smartNodeSelector tags)
…ns-fixes' into improve-realization-filter
- Fix minor issues with smartNodeSelector - To prevent complicated state handling of smartNodeSelector tags and parameter list, change functionality s.t. smartNodeSelector is used as a selector, and add button is included to add these active selections to the list of parameters below. - Fix hover info on unavailable reals in real number display
- Invalid tags - Already selected parameters
Create ranges based on sequence occurrence in valid realizations. To reduce number of ranges if an ensemble contains a lot of invalid realization numbers.
Move component from framework/components to framework/internal/components
jorgenherje
requested review from
rubenthoms,
HansKallekleiv,
Anders2303 and
anders-kiaer
and removed request for
rubenthoms
HansKallekleiv
approved these changes
Oct 25, 2024
anders-kiaer
approved these changes
Oct 28, 2024
- Show hover info for display when filter is inactive - Allow save/discard buttons on click when filter is inactive
jorgenherje
force-pushed
the
improve-realization-filter
branch
from
4aee918 to
3ddb859
Compare
Anders2303
reviewed
Nov 1, 2024
.../internal/components/EnsembleRealizationFilter/private-components/byParameterValueFilter.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the RealizationFilter, by including a filter for each selected ensemble.
Upgrades to Realization Filter:
SmartNodeSelector:
onChangedatanodeIdsto be correct when using wildcardonChangeto trigger when clicking outside of componentsThe PR closes the following issues:
Closes: #690
Closes: #691
Closes: #321
Closes: #722