Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCB Update #3

Merged
merged 3 commits into from
Dec 11, 2023
Merged

PCB Update #3

merged 3 commits into from
Dec 11, 2023

Conversation

Ladniy
Copy link
Collaborator

@Ladniy Ladniy commented Dec 7, 2023

Edits asked by @yumagulovrn

  • Edit PCB's outline fillets, now then 1mm in radius, instead of 0.5
  • Re-fill zones

@Ladniy
Copy link
Collaborator Author

Ladniy commented Dec 7, 2023

@pashutk @yumagulovrn review PR please

@pashutk
Copy link
Member

pashutk commented Dec 10, 2023

Great job, I see that the board outline arcs now 1.0mm radius.

Here's a couple of suggestions that could improve this PR:

  • Let's update arcs for the battery cutout as well
  • And I suggest bumping the version of the board to v1.2

cc @Ladniy @yumagulovrn

@Ladniy
Copy link
Collaborator Author

Ladniy commented Dec 10, 2023

  • Let's update arcs for the battery cutout as well

Sure, i'll do it

  • And I suggest bumping the version of the board to v1.2

On the silkscreen of PCB or somewhere else too?

@pashutk

@pashutk
Copy link
Member

pashutk commented Dec 10, 2023

I believe a silkscreen text change would be sufficient

@Ladniy
Copy link
Collaborator Author

Ladniy commented Dec 10, 2023

Done with these commits:

ce7b292

a6c49e7

@pashutk

@pashutk
Copy link
Member

pashutk commented Dec 11, 2023

LGTM, approved

@Ladniy Ladniy merged commit d132c7a into main Dec 11, 2023
1 check passed
@Ladniy Ladniy deleted the fillet-fix branch December 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ladniy @pashutk