Added metrics for observed waypoints #12785
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastorski
force-pushed
the
eastorski/waypoint-metrics
branch
from
85ba297
to
b0128ad
Compare
taratorio
reviewed
Nov 19, 2024
| @@ -31,6 +31,8 @@ var ( | |||
| BlockConsumerPreExecutionDelay = metrics.NewSummary(`block_consumer_delay{type="pre_execution"}`) | |||
| BlockConsumerPostExecutionDelay = metrics.NewSummary(`block_consumer_delay{type="post_execution"}`) | |||
| BlockProducerProductionDelay = metrics.NewSummary(`block_producer_delay{type="production"}`) | |||
| ObservedWaypointCheckpointLength = metrics.NewSummary(`observed_waypoint_length{type="checkpoint"}`) | |||
There was a problem hiding this comment.
would suggest to move these inside the heimdall package
taratorio
reviewed
Nov 19, 2024
polygon/sync/tip_events.go
Outdated
| @@ -201,6 +203,16 @@ func (te *TipEvents) Run(ctx context.Context) error { | |||
| }, heimdall.WithEventsLimit(5)) | |||
| defer milestoneObserverCancel() | |||
|
|
|||
| metricsMilestoneObserverCancel := te.heimdallObserverRegistrar.RegisterMilestoneObserver(func(milestone *heimdall.Milestone) { | |||
There was a problem hiding this comment.
would suggest to move these inside the heimdall package, can be registered as background daemons of the heimdall.Service inside its Run method
There was a problem hiding this comment.
moved to heimdall
taratorio
reviewed
Nov 19, 2024
| @@ -31,6 +31,8 @@ var ( | |||
| BlockConsumerPreExecutionDelay = metrics.NewSummary(`block_consumer_delay{type="pre_execution"}`) | |||
| BlockConsumerPostExecutionDelay = metrics.NewSummary(`block_consumer_delay{type="post_execution"}`) | |||
| BlockProducerProductionDelay = metrics.NewSummary(`block_producer_delay{type="production"}`) | |||
| ObservedWaypointCheckpointLength = metrics.NewSummary(`observed_waypoint_length{type="checkpoint"}`) | |||
| ObservedWaypointMilestoneLength = metrics.NewSummary(`observed_waypoint_length{type="milestone"}`) | |||
There was a problem hiding this comment.
do we need these to be summary-ies or would not a gauge metric type be more suitable?
eastorski
force-pushed
the
eastorski/waypoint-metrics
branch
from
b0128ad
to
8559b2d
Compare
taratorio
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.