Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block building fixes found for large deposit requests set #12804

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Nov 20, 2024

  • Add requests sidecar to Seal func
  • Additional logging for better debugging on live networks
  • Fix issue with requests in getPayload API

@somnathb1
Copy link
Contributor Author

Tests performed with Kurtosis is as follows (thanks to pk910 from ethpandaops)

assertoor_params:
  run_stability_check: false
  run_block_proposal_check: false
  tests:
    - { file: "https://raw.githubusercontent.com/ethpandaops/assertoor/refs/heads/electra-support/playbooks/pectra-dev/kurtosis/fillup-deposit-queue.yaml", config: { depositCount: 25000, depositMaxIndex: 500 }}

Getting all the deposit requests fine on blocks produced by Erigon, as seen in this image:
Screenshot From 2024-11-20 14-37-23

@somnathb1 somnathb1 added the pectra The Prague/Electra protocol upgrade label Nov 20, 2024
@somnathb1
Copy link
Contributor Author

Cherry picked the commits from pectra_e2 will merge back after this commit, so pectra_e2 will be 100% the same as release after this.

@somnathb1 somnathb1 merged commit 2148546 into release/2.61 Nov 20, 2024
5 checks passed
@somnathb1 somnathb1 deleted the som/sync branch November 20, 2024 11:37
yperbasis added a commit that referenced this pull request Nov 20, 2024
Cherry pick PR #12804 into `main`

Co-authored-by: Somnath <snb895@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants