Migrate and Extend Price Module #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved over the pricing module to be within the Catalog assembly. Taking a more "monolithic" approach until there are enough use cases and such to demonstrate how to migrate and separate the services. Which may not be necessary at all!
Currently retired use of Plumbr, but will circle back to it once more work is done with Eventuous and presentations at conferences and user groups are done. Can have a more "Completed A, B, and C" set of work to look at and then implement the same thing using Plumbr, etc. Rather than trying to leverage both libraries right off the rip.