Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefinition of _CRT_SECURE_NO_WARNINGS macro #800

Closed
DDeimos opened this issue Sep 21, 2024 · 1 comment
Closed

Redefinition of _CRT_SECURE_NO_WARNINGS macro #800

DDeimos opened this issue Sep 21, 2024 · 1 comment

Comments

@DDeimos
Copy link

DDeimos commented Sep 21, 2024

Hi!
There are several sources with #define _CRT_SECURE_NO_WARNINGS. I believe there should be #ifdef first for projects which have already defined the macro. In my case I get a lot of warnings because I defined the macro in my project settings to suppres GLFW warnings. I could workaround it, but I think that #ifdef would be better in any case.
erincatto added a commit that referenced this issue Sep 26, 2024
@erincatto
issues #800 #798 #794
1e6de4e
@erincatto
Copy link
Owner

Fixed in #804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DDeimos @erincatto