Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebar3 master #480

Closed
wants to merge 8 commits into from
Closed

Rebar3 master #480

wants to merge 8 commits into from

Conversation

Juliusan
Copy link

I use Yaws on Erlang OTP26 and I also build my projects using rebar3. I know, there is a rebar compatibility branch rebar3-support, however, it is too old and doesn't work with OTP26. Moreover, master branch of Yaws is updated to OTP26, but it has problems building all C dependencies using rebar3. I've merged these two branches. Please either use this PR to include rebar3 compatibility in master branch or make a rebase on master of rebar3-support.

oubiwann and others added 8 commits March 24, 2022 12:44
Use a post hook to remove Makefile.am files copied along with source
files to the build area.

Update the port_compiler version to 1.10.1.
Versions 1.10.x of the port_compiler have problems finding C source
files:

===> Found no source files for:
"c_src/epam.c"
===> Found no source files for:
"c_src/setuid_drv.c"

Pinning the version to 1.9.1 avoids this problem.
Since rebar3 doesn't need a top-level ebin directory, Move ebin to
ebin_src and make src/Makefile.am create the ebin directory as needed.

Rename the testsuite directory to test, which is the default rebar3
looks for. Note that running tests under rebar3 still doesn't work,
though; more work is required.

Rename the obsolete rel directory to rel.obsolete. Rename the obsolete
rebar-templates directory to rebar2-templates. These are being kept
for now as the files they contain will likely be useful as rebar3 work
continues.

Use version 1.11.0 of the port_compiler, since problems noted in
previous commits are now fixed.
Due to the ssl:cipher_suites/0 deprecation warning, change the dev
profile in rebar.config to drop the warnings_as_errors setting. It's
still enabled in the prod profile.
Fix issues related to deterministic builds after rebasing yaws-2.1.1
to rebar3-support. Make rebar3 create the gen-yaws-generated script.
@vinoski
Copy link
Collaborator

vinoski commented Jan 26, 2024

Thanks, I'll take a look.

@vinoski
Copy link
Collaborator

vinoski commented Jan 26, 2024

@Juliusan, question: I assume that rebar3 eunit or rebar3 ct still don't work with your changes?

@Juliusan
Copy link
Author

@Juliusan, question: I assume that rebar3 eunit or rebar3 ct still don't work with your changes?

"My changes" is saying it too loud :-D I just merged two existing branches and fixed a few merge conflicts, which occurred in make file and documentation.

To answer your question: I use yaws as a dependency and haven't tried running tests on it. But yes, you are right. Both eunit and ct fail with 'export_all flag enabled - all functions will be exported' in different files.

Shouldn't be hard to fix that, I suppose. And it is supposed to be a warning. I'll have a look.

@vinoski
Copy link
Collaborator

vinoski commented Jan 26, 2024

No need to fix the export_all issue, I already have it fixed locally. But there are more problems after fixing that.

I was asking about the rebar3 commands just so I would know what to expect when reviewing your PR. Thanks for the clarification!

@vinoski
Copy link
Collaborator

vinoski commented Feb 14, 2024

I'm still working on this.

@vinoski
Copy link
Collaborator

vinoski commented Feb 19, 2024

I manually rebased the whole branch and updated it to fix a few things, then merged it to master as a single commit. Thanks for pushing this forward!

@vinoski vinoski closed this Feb 19, 2024
@Juliusan
Copy link
Author

Thank you for doing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants