Add ersilia base image docker upload to Ersilia Release workflow #1297

rohitgupta29 · 2024-10-06T10:00:14Z

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

Have you followed the guidelines in our Contribution Guide
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Description

Moved the docker build job from workflow to add as a parallel job in Ersilia Release (https://github.com/ersilia-os/ersilia/blob/master/.github/workflows/publish.yaml)

Changes to be made

Add Docker build job to Ersilia Release (https://github.com/ersilia-os/ersilia/blob/master/.github/workflows/publish.yaml) Workflow.

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1297

.github/workflows/publish.yaml

…dd_ersilia_docker_to_release

…hitgupta29/ersilia into add_ersilia_docker_to_release

DhanshreeA · 2024-10-10T08:32:56Z

@rohitgupta29 Please resolve conflicts on this PR

…ments

P-Mefut · 2024-10-12T05:40:33Z

.circleci/config.yml

+              ersilia api -i "CCC" > output_one_0.json
+              ersilia api -i "CCC" -o output_one_1.json
+              ersilia api -i "CCC" -o output_one_3.csv
+              ersilia api -i test/inputs/compound_list.csv > output_list_0.json


Hi @rohitgupta29 I think the api command was removed from the CLI and if you pulled changes as @DhanshreeA requested you'll notice...

Hi @P-Mefut!
I am checking it and will share about it in some time.

Hi @P-Mefut ...Can you share a bit more more details on this?
For my repo, it does not show code from line 58 (ersilia api -i test/inputs/compound_list.csv > output_list_0.json), after pull also.

@rohitgupta29 this is because you first need to sync your fork of ersilia from the original ersilia repo, and then pull those changes locally (because your fork is your remote, and not the original ersilia repo)

Thanks for the catch @P-Mefut !

P-Mefut · 2024-10-12T05:46:39Z

##Hi @rohitgupta29 please pull changes and you'll see codes that have been removed from the ersilia ClI such as the api command which you still have in your workflow. Also I think we should leave easy to understand comments within the code for newbies to code to easily understand the workflow and how to interact with it...

rohitgupta29 · 2024-10-12T09:04:22Z

##Hi @rohitgupta29 please pull changes and you'll see codes that have been removed from the ersilia ClI such as the api command which you still have in your workflow. Also I think we should leave easy to understand comments within the code for newbies to code to easily understand the workflow and how to interact with it...

Thanks @P-Mefut. Thanks for the feedback. I will add the comments today. 👍

DhanshreeA · 2024-10-12T14:07:30Z

.circleci/config.yml

+              ersilia api -i "CCC" > output_one_0.json
+              ersilia api -i "CCC" -o output_one_1.json
+              ersilia api -i "CCC" -o output_one_3.csv
+              ersilia api -i test/inputs/compound_list.csv > output_list_0.json


@rohitgupta29 this is because you first need to sync your fork of ersilia from the original ersilia repo, and then pull those changes locally (because your fork is your remote, and not the original ersilia repo)

DhanshreeA · 2024-10-12T14:07:48Z

.circleci/config.yml

+              ersilia api -i "CCC" > output_one_0.json
+              ersilia api -i "CCC" -o output_one_1.json
+              ersilia api -i "CCC" -o output_one_3.csv
+              ersilia api -i test/inputs/compound_list.csv > output_list_0.json


Thanks for the catch @P-Mefut !

DhanshreeA · 2024-10-12T14:08:53Z

@rohitgupta29 please sync your fork with the latest changes in ersilia, and then pull those locally, and then please rebase your branch and push again. Thanks! Presently you have older code that has been modified.

…dd_ersilia_docker_to_release

rohitgupta29 · 2024-10-12T18:30:06Z

@rohitgupta29 please sync your fork with the latest changes in ersilia, and then pull those locally, and then please rebase your branch and push again. Thanks! Presently you have older code that has been modified.

Thank you @P-Mefut for noticing it. Now, my fork is in sync with the latest changes :)

Thank you @DhanshreeA for helping here. Have updated the code with code comments for updated parts.

DhanshreeA · 2024-10-13T07:45:05Z

@rohitgupta29 I do not see the latest changes on this PR still. Please fix this, otherwise this can't be merged.

P-Mefut · 2024-10-13T07:55:20Z

@rohitgupta29 You need to sync your forked repo with the official Ersilia repo before this can be merged so as to resolve any merge conflicts...

rohitgupta29 · 2024-10-13T11:28:55Z

@rohitgupta29 I do not see the latest changes on this PR still. Please fix this, otherwise this can't be merged.

Hi @DhanshreeA @P-Mefut , I have synced my latest changes in this pull request. I have also synced my fork with the ersilia repository.
Can you guide me if i am missing anything?

P-Mefut · 2024-10-13T11:43:20Z

hi @rohitgupta29 yes you have synced the repo but you still have the api command in your config.yml file

rohitgupta29 · 2024-10-13T11:52:16Z

hi @rohitgupta29 yes you have synced the repo but you still have the api command in your config.yml file

Hi @P-Mefut ,
I can see these api commands you have shared in the ersilia github repo also.

P-Mefut · 2024-10-13T12:02:19Z

hi @rohitgupta29 yes you have synced the repo but you still have the api command in your config.yml file

Hi @P-Mefut , I can see these api commands you have shared in the ersilia github repo also.

config.yml @rohitgupta29 here's the file where you have used the unsupported api command and you need to update it before merging would be possible...

rohitgupta29 · 2024-10-13T12:17:00Z

hi @rohitgupta29 yes you have synced the repo but you still have the api command in your config.yml file

Hi @P-Mefut , I can see these api commands you have shared in the ersilia github repo also.

config.yml @rohitgupta29 here's the file where you have used the unsupported api command and you need to update it before merging would be possible...

Thank you so much @P-Mefut for clearifying. It helped me realize the needed. Will take care of such things ahead. Have updated the config.yml file :)

rohitajay added 2 commits October 6, 2024 15:21

add docker build image job to publish.yaml

8ab7a77

delete ersilia-base-image-to-dockerhub.yml

976300a

rohitgupta29 changed the title ~~add docker build image job to publish.yaml~~ Add ersilia base image docker upload to Ersilia Release workflow Oct 6, 2024

DhanshreeA requested changes Oct 9, 2024

View reviewed changes

.github/workflows/publish.yaml Show resolved Hide resolved

DhanshreeA and others added 4 commits October 9, 2024 14:14

Merge branch 'master' into add_ersilia_docker_to_release

2350e26

update upload-ersilia-base-to-dockerhub in publish.yaml

ed07532

Merge branch 'master' of https://github.com/ersilia-os/ersilia into a…

af0003f

…dd_ersilia_docker_to_release

Merge branch 'add_ersilia_docker_to_release' of https://github.com/ro…

bd7d63f

…hitgupta29/ersilia into add_ersilia_docker_to_release

DhanshreeA approved these changes Oct 10, 2024

View reviewed changes

update upload-ersilia-base-to-dockerhub in publish.yaml wtih code com…

15a8063

…ments

P-Mefut reviewed Oct 12, 2024

View reviewed changes

DhanshreeA requested changes Oct 12, 2024

View reviewed changes

rohitajay added 2 commits October 12, 2024 20:58

Merge branch 'master' of https://github.com/ersilia-os/ersilia into a…

9aacc46

…dd_ersilia_docker_to_release

update code comments for publish.yml

e8d62de

DhanshreeA and others added 2 commits October 13, 2024 14:38

Merge branch 'master' into add_ersilia_docker_to_release

7333a21

update with code and comments for publish.yml

22c427e

updated ersilia api to ersilia run in config.yml

8394450

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ersilia base image docker upload to Ersilia Release workflow #1297

Add ersilia base image docker upload to Ersilia Release workflow #1297

rohitgupta29 commented Oct 6, 2024 •

edited

Loading

DhanshreeA commented Oct 10, 2024

P-Mefut Oct 12, 2024

rohitgupta29 Oct 12, 2024 •

edited

Loading

rohitgupta29 Oct 12, 2024

DhanshreeA Oct 12, 2024

DhanshreeA Oct 12, 2024

P-Mefut commented Oct 12, 2024

rohitgupta29 commented Oct 12, 2024

DhanshreeA Oct 12, 2024

DhanshreeA Oct 12, 2024

DhanshreeA commented Oct 12, 2024

rohitgupta29 commented Oct 12, 2024

DhanshreeA commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024 •

edited

Loading

Add ersilia base image docker upload to Ersilia Release workflow #1297

Are you sure you want to change the base?

Add ersilia base image docker upload to Ersilia Release workflow #1297

Conversation

rohitgupta29 commented Oct 6, 2024 • edited Loading

DhanshreeA commented Oct 10, 2024

P-Mefut Oct 12, 2024

Choose a reason for hiding this comment

rohitgupta29 Oct 12, 2024 • edited Loading

Choose a reason for hiding this comment

rohitgupta29 Oct 12, 2024

Choose a reason for hiding this comment

DhanshreeA Oct 12, 2024

Choose a reason for hiding this comment

DhanshreeA Oct 12, 2024

Choose a reason for hiding this comment

P-Mefut commented Oct 12, 2024

rohitgupta29 commented Oct 12, 2024

DhanshreeA Oct 12, 2024

Choose a reason for hiding this comment

DhanshreeA Oct 12, 2024

Choose a reason for hiding this comment

DhanshreeA commented Oct 12, 2024

rohitgupta29 commented Oct 12, 2024

DhanshreeA commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024

P-Mefut commented Oct 13, 2024

rohitgupta29 commented Oct 13, 2024 • edited Loading

rohitgupta29 commented Oct 6, 2024 •

edited

Loading

rohitgupta29 Oct 12, 2024 •

edited

Loading

rohitgupta29 commented Oct 13, 2024 •

edited

Loading