Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Invalid YAML in workflows install.yml #791

Closed
DhanshreeA opened this issue Aug 28, 2023 · 3 comments
Closed

🐛 Bug: Invalid YAML in workflows install.yml #791

DhanshreeA opened this issue Aug 28, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Aug 28, 2023

Describe the bug.

The YAML check for install.yml in GitHub Actions workflows fails because this YAML is invalid. (Occurred here first: #790 (comment))
This is because the steps key is duplicated within jobs.base. As per my understanding, probably the idea here is to test ersilia installation sans bentoml. One possible solution to fix this workflow is to create two separate jobs, one for installing ersilia with bentoml, the other for installing it without bentoml. Something like:

jobs:
  with_bentoml:
    strategy:
      matrix:
        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v2
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install Ersilia
      run: |
        python -m pip install git+https://github.com/ersilia-os/bentoml-ersilia.git
        python -m pip install -e .
    - name: Test help command
      run: |
        ersilia --help
        ersilia --version
  without_bentoml:
    steps:
    - uses: actions/checkout@v2
    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v2
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install Ersilia without pre-installing BentoML
      run: |
        python -m pip install -e .
    - name: Test help command again
      run: |
        ersilia --help
        ersilia --version
    - name: Fetch molecular weight model from DockerHub
      run: |
        ersilia -v fetch molecular-weight --from_dockerhub

Describe the steps to reproduce the behavior

No response

Expected behavior.

No response

Screenshots.

No response

Operating environment

NA

Additional context

No response

@DhanshreeA DhanshreeA added the bug Something isn't working label Aug 28, 2023
@DhanshreeA
Copy link
Member Author

@miquelduranfrigola please look.

@GemmaTuron
Copy link
Member

I see this is the issue:

Invalid workflow file: .github/workflows/install.yml#L32
You have an error in your yaml syntax on line 32

https://github.com/ersilia-os/ersilia/actions/runs/5996643301

@GemmaTuron
Copy link
Member

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants