🐛 Bug: /approve command triggers workflows outside the "Model Request" issue template

[miquelduranfrigola]

Describe the bug.

The /approve command triggers workflows to create a model repository when an Ersilia Maintainer approves a model request issue. This workflow runs every time a user (possibly only Ersilia maintainers) comment on any issue within this repository, whereas this workflow should be triggered only when the related issue is a "Model Request" issue.

This is a good first issue and provides a starting point for learning more about GitHub actions. The workflow being referenced is implemented here.

This can potentially be fixed by making the job within this workflow execute conditionally based on the issue label. You can find an example here.

Describe the steps to reproduce the behavior

You can see the number of times this action has run where it was not relevant here.

To reproduce this issue yourself, please open an issue, and tag one of the maintainers to comment on it. Once a maintainer comments on it, the workflow will be triggered.

Expected behavior.

One possibility would be to modify the first triggered action to check for a new-model, as suggested by @GrantBirki .

To make sure the implemented fix works, please tag a maintainer to post a comment on an issue and verify if the workflow no longer gets triggered.

Screenshots.

No response

Operating environment

Ubuntu 20.04 LTS

Additional context

No response

[GemmaTuron]

Is this a persisting issue? seems quite straightforward to fix. Perhaps a good first issue?

[DhanshreeA]

I agree - straightforward. We simply need to add a label filter in this workflow, like we have it in ersilia-self-service.

[Ajoke23]

Hi @DhanshreeA. Could you please assign me this task?

[DhanshreeA]

@Ajoke23 we need to close your current PRs first before assigning more issues to you. :)

[Ajoke23]

@Ajoke23 we need to close your current PRs first before assigning more issues to you. :)

No problem @DhanshreeA. Please have a look at pull request #1284.

[aderemi1224]

@DhanshreeA I am done with my first task, can you please assign this to me?

[DhanshreeA]

@aderemi1224 go ahead!

[aderemi1224]

Thank you @DhanshreeA

[Ajoke23]

Hi @aderemi1224. Any progress with this issue?

Do you need help?

[aderemi1224]

Yes please @Ajoke23

[Ajoke23]

Can you share what you have done so far so that I can know how to be of assistance to you?

Or better open a pull request with your progress. With that it's easier to track

Yes please @Ajoke23

[dzumii]

Hi @aderemi1224 can you share your progress with us on this issue?

[aderemi1224]

@dzumii i got stuck but know my around to solve the problem now.

[Ajoke23]

I saw your message on slack now saying you are getting error.
https://ersilia-outreachy-w24.slack.com/archives/C07LR4F237Y/p1728297346707509?thread_ts=1728280031.015259&cid=C07LR4F237Y

https://ersilia-outreachy-w24.slack.com/archives/C07LR4F237Y/p1728297446073079?thread_ts=1728280031.015259&cid=C07LR4F237Y
Did you try this?

[aderemi1224]

@DhanshreeA i have made the changes requested

[aderemi1224]

@DhanshreeA i have made the changes.