Modifying the local Catalog functionality #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhanshreeA
requested changes
Jul 12, 2024
ersilia/default.py
Outdated
| @@ -30,6 +30,7 @@ | |||
| LOGGING_FILE = "console.log" | |||
| CURRENT_LOGGING_FILE = "current.log" | |||
| CARD_FILE = "card.json" | |||
| LOCAL_CARD_FILE = "information.json" | |||
There was a problem hiding this comment.
We already have a file called INFORMATION_FILE, do we need to create another one?
ersilia/hub/content/card.py
Outdated
| @@ -45,7 +46,7 @@ | |||
| except: | |||
| Hdf5Explorer = None | |||
|
|
|||
| from ...default import CARD_FILE, METADATA_JSON_FILE, SERVICE_CLASS_FILE | |||
| from ...default import EOS, LOCAL_CARD_FILE, METADATA_JSON_FILE, SERVICE_CLASS_FILE | |||
There was a problem hiding this comment.
I don't understand where 'LOCAL_CARD_FILE' is being written to for your code to be able to read it. If it is the same information file as i mentioned above, in that case, you can reuse that same identifier instead of creating a new one.
|
@DhanshreeA , you are right, there's no need to create a new file, when we have an existing file that serves the same function. I've modified the PR to reflect this. |
Update card.py
DhanshreeA
requested changes
Jul 13, 2024
|
Looks pretty good @Malikbadmus , thanks for implementing all the suggestions. Merging this now. |
DhanshreeA
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Utilizing
information.jsoninstead of the AirTable database to populate the local model card.Changes to be made
LocalCardclass method.Status
ersilia catalog --local --morecommand now takes between 0.5s-0.8s, representing an almost 97% improvement in performance.Related to #1072