Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the Ersilia Current command #1282

Closed
wants to merge 9 commits into from

Conversation

Ajoke23
Copy link
Contributor

@Ajoke23 Ajoke23 commented Oct 2, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Remove the Ersilia current command

Changes to be made

  • Deleting of the current command line i.e cmd.current()
  • Removal the cmd function which is the command implememtation code in
    Status

To do
None

Related to #1267

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 3, 2024

@DhanshreeA I will be expecting your feedback

@P-Mefut
Copy link

P-Mefut commented Oct 3, 2024

hi @Ajoke23, looks good but we still have a def for current in the cmd.py files

def current(self): m = importlib.import_module("ersilia.cli.commands.current") m.current_cmd()

that's line 32 - 34 which should be removed if your taking out the command

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 3, 2024

Hi @DhanshreeA
The following steps were taking to successfully remove current command:

  • removed cmd.current() from create_cli.py
  • deleted the curent.py file since the code there aren't needed
  • I removed the def function for current found in cmd.py file
    I tested the code locally and the result shows that current command has been successfully removed
current command not found

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 3, 2024

hi @Ajoke23, looks good but we still have a def for current in the cmd.py files

def current(self): m = importlib.import_module("ersilia.cli.commands.current") m.current_cmd()

that's line 32 - 34 which should be removed if your taking out the command

Thanks for the suggestion.

@Ajoke23 Ajoke23 mentioned this pull request Oct 3, 2024
3 tasks
@dzumii
Copy link
Contributor

dzumii commented Oct 5, 2024

Hello @Ajoke23, I can see you already created another pull request here, can you confirm we can disregard and close this then?

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 5, 2024

Hello @Ajoke23, I can see you already created another pull request here, can you confirm we can disregard and close this then?

Yes, you can close this particular pull request #1282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants