Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Ersilia current command #1284

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

Ajoke23
Copy link
Contributor

@Ajoke23 Ajoke23 commented Oct 3, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Remove/De-register the ersilia current command. The main aim is to make sure that when anyone run ersilia current it would return the error below

Error: No such command 'current

Changes to be made

  • Delete current.cmd() line of code
  • Delete all line of code in current.py
  • Deleted the entire current.py file since it's empty.

Status

  • Successfully removed the current command
  • I ran the ersilia current locally (using codespace) and got the following output below:
    output.log

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1267

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 3, 2024

Hi @DhanshreeA
I have successfully removed the current command. I have attached output after testing it locally
successfully removal of current command

This is the main pull request. I have initially created a pull request yesterday for this same task. Can i go ahead of close the previous pull request #1282 ?

CC @GemmaTuron

@P-Mefut
Copy link

P-Mefut commented Oct 3, 2024

hi @Ajoke23 isn't this a duplicate PR to the one you previously opened?

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 3, 2024

hi @Ajoke23 isn't this a duplicate PR to the one you previously opened?

Yes, it's. This is the pull request I want @DhanshreeA to go through because I created a new branch name remove-current-command in relation to this issue rather than the previous branch name. I wanted the branch name to give an insight of the issue.
I am waiting for feedback from @DhanshreeA if I can go ahead and close pull request #1282 since it's duplicate

@adebisi4145
Copy link
Contributor

adebisi4145 commented Oct 4, 2024

Yes, it's. This is the pull request I want @DhanshreeA to go through because I created a new branch name remove-current-command in relation to this issue rather than the previous branch name. I wanted the branch name to give an insight of the issue.
I am waiting for feedback from @DhanshreeA if I can go ahead and close pull request #1282 since it's duplicate

Welldone @Ajoke23, next time you can just rename the branch from github.

Here's a detailed explanation on how to go about it

@dzumii
Copy link
Contributor

dzumii commented Oct 6, 2024

@Ajoke23 You can also run the ersilia current command (before and after you made changes) and post the output here

Delete the current.py file since it's not needed
@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 7, 2024

@Ajoke23 You can also run the ersilia current command (before and after you made changes) and post the output here

Hi @dzumii I posted the output after changes was made above. Incase you might have missed that, please I have attached the link below for your view:
#1284 (comment)

@dzumii
Copy link
Contributor

dzumii commented Oct 8, 2024

@DhanshreeA I have tested and reviewed this PR and I think this is good to go

@DhanshreeA
Copy link
Member

Hi @DhanshreeA I have successfully removed the current command. I have attached output after testing it locally successfully removal of current command

This is the main pull request. I have initially created a pull request yesterday for this same task. Can i go ahead of close the previous pull request #1282 ?

CC @GemmaTuron

@Ajoke23 in the screen shot you have shared, it seems you are not running the ersilia command correctly itself. It is spelled as erisilia in your screen shot.

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 8, 2024

Hi @DhanshreeA that was a typo error. I ran it again correctly by running ersilia current and i got this output

Hi @DhanshreeA I have successfully removed the current command. I have attached output after testing it locally successfully removal of current command

This is the main pull request. I have initially created a pull request yesterday for this same task. Can i go ahead of close the previous pull request #1282 ?

CC @GemmaTuron

@Ajoke23 in the screen shot you have shared, it seems you are not running the ersilia command correctly itself. It is spelled as erisilia in your screen shot.

@P-Mefut
Copy link

P-Mefut commented Oct 8, 2024

@Ajoke23 you should pull the merged changes so as to avoid conflicts, also @DhanshreeA I've ran the test and her changes are in good standing ready to be merged:)

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 8, 2024

Hi @P-Mefut I have the changes pulled since I saw it.
Thanks for your suggestion

@P-Mefut
Copy link

P-Mefut commented Oct 8, 2024

Okay great @Ajoke23, your work ready to be merged then... I've ran the test and it's in good standing...

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 8, 2024

Okay great @Ajoke23, your work ready to be merged then... I've ran the test and it's in good standing...

Thanks a lot. @dzumii also tested it too and it was also successful. I am sure @DhanshreeA will merge it soonest, I believe so.

@DhanshreeA DhanshreeA merged commit 1d54d56 into ersilia-os:master Oct 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants