Update approve-trigger.yml #1300
Open
+26
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DhanshreeA Please kindly review |
|
@aderemi1224 Have you tested your changes? If yes, can you share details with us regarding your test before and after the changes were made? |
DhanshreeA
requested changes
Oct 9, 2024
I have removed the steps that log messages related to the approval process and label checking. The workflow now triggers the approval command when the 'Model Request' label is detected, streamlining the process by eliminating log outputs.
DhanshreeA
requested changes
Oct 10, 2024
| reactions: false | ||
| commands: | | ||
| approve | ||
| - name: Approve Command Trigger |
There was a problem hiding this comment.
We should keep the single tab indentation
There was a problem hiding this comment.
@aderemi1224 can you please restore the indentation?
DhanshreeA
requested changes
Oct 10, 2024
| jobs: | ||
| approve-command-trigger: | ||
| if: contains(github.event.issue.labels.*.name, 'Model Request') |
There was a problem hiding this comment.
The label is actually called new-model, and not Model Request.
There was a problem hiding this comment.
Refer here, for example: https://github.com/ersilia-os/ersilia/issues?q=is%3Aopen+is%3Aissue+label%3Anew-model
Indentation has been restored
|
@DhanshreeA I have made changes |
DhanshreeA
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
This project addresses the current implementation of the /approve command in the Ersilia repository, which unintentionally triggers workflows to create a model repository for any comment made on any issue. The objective is to refine this functionality so that the workflow is executed only for "new-model" issues. Originally, the workflow would activate for any comment on any issue, without checking if the issue was related to creating a new model. This led to unwanted triggers.
Changes to be made
if: contains(github.event.issue.labels.*.name, 'new-model')
This ensures that the workflow does not activate for every comment but is instead filtered to respond only when a specific label is applied to the issue.
Status
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #962