Drop Python 3.7 support and update tests #1316
Conversation
|
@DhanshreeA please can you check this out please |
| @@ -10,7 +10,6 @@ repository = "https://github.com/ersilia-os/ersilia" | |||
| documentation = "https://ersilia.io/model-hub" | |||
| keywords= ["drug-discovery", "machine-learning", "ersilia", "open-science", "global-health", "model-hub", "infectious-diseases"] | |||
| classifiers=[ | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
There was a problem hiding this comment.
How about added support for python 3.11 here since you've already added it in your code above
There was a problem hiding this comment.
so you mean I should add python version 3.11 right?
There was a problem hiding this comment.
While you are at it, please mention 3.12 as well, thank you!
| @@ -11,7 +11,7 @@ jobs: | |||
| install-ersilia: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
There was a problem hiding this comment.
I think we can also add 3.12 to this list since we support 3.12 as well.
| @@ -32,7 +32,7 @@ jobs: | |||
| test-docker: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
There was a problem hiding this comment.
Same as above, we can include 3.12 as well.
| @@ -10,7 +10,6 @@ repository = "https://github.com/ersilia-os/ersilia" | |||
| documentation = "https://ersilia.io/model-hub" | |||
| keywords= ["drug-discovery", "machine-learning", "ersilia", "open-science", "global-health", "model-hub", "infectious-diseases"] | |||
| classifiers=[ | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
There was a problem hiding this comment.
While you are at it, please mention 3.12 as well, thank you!
pyproject.toml
Outdated
| @@ -49,7 +47,7 @@ numpy = "<=1.26.4" | |||
| isaura = {version="0.1", optional=true} | |||
| pytest = {version = "^7.4.0", optional = true} | |||
| fuzzywuzzy = {version = "^0.18.0", optional = true} | |||
| sphinx = {version = ">=5.3.0", optional = true} # For compatibility with python 3.7.x | |||
| sphinx = {version = ">=5.3.0", optional = true} | |||
There was a problem hiding this comment.
Maybe we actually check which is the minimum version we need for 3.8?
…hix minimum version that support python version 3.8
…-glitch/ersilia into drop-python3.7-support
|
@DhanshreeA please I made the changes and also worked on your request, kindly verify and let me know if there is anything i need to do , thank you |
|
@DhanshreeA Hello ma, please I am seeing some failures, working to resolve that please. |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Updated the pyproject.toml file to drop all dependencies support 3.7 , removed tests concerned with python version 3.7
Changes to be made
Replace this line with how do you intend to go about getting this done...
Status
Updated the pyroject.toml file and changed all python version from 3.7 to 3.8
To do
If this is a work in progress, Replace this line with your next steps
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1226