Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.7 support and update tests #1316

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+11 −10
Open

Drop Python 3.7 support and update tests #1316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ce9669
Drop Python 3.7 support and update tests
Darkbeast-glitch Oct 10, 2024
4ecc8ed
Merge branch 'master' into drop-python3.7-support
DhanshreeA Oct 12, 2024
e0608f9
Update Python versions in workflows and pyproject.toml and changed sp…
Darkbeast-glitch Oct 13, 2024
83588ef
Merge branch 'drop-python3.7-support' of https://github.com/Darkbeast…
Darkbeast-glitch Oct 13, 2024
b3b2772
Merge branch 'master' into drop-python3.7-support
DhanshreeA Oct 14, 2024
772b6f4
Update Docker images to support Python 3.8 in CircleCI config.yml
Darkbeast-glitch Oct 14, 2024
50c986b
Merge branch 'drop-python3.7-support' of https://github.com/Darkbeast…
Darkbeast-glitch Oct 14, 2024
39173cd
Merge branch 'master' into drop-python3.7-support
DhanshreeA Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests_and_cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
install-ersilia:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also add 3.12 to this list since we support 3.12 as well.

runs-on: ubuntu-latest

steps:
Expand All @@ -32,7 +32,7 @@ jobs:
test-docker:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, we can include 3.12 as well.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Added by Ersilia

# Environment variables
.env
*.pyc
*.vscode
*.code-workspace
Expand Down
6 changes: 2 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ repository = "https://github.com/ersilia-os/ersilia"
documentation = "https://ersilia.io/model-hub"
keywords= ["drug-discovery", "machine-learning", "ersilia", "open-science", "global-health", "model-hub", "infectious-diseases"]
classifiers=[
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about added support for python 3.11 here since you've already added it in your code above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you mean I should add python version 3.11 right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, please mention 3.12 as well, thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure please on it

Expand All @@ -27,11 +26,10 @@ include = [
]

[tool.poetry.dependencies]
python = ">=3.7"
python = ">=3.8"
inputimeout = "^1.0.4"
emoji = "^2.8.0"
validators = [
{version="0.20.0", python="3.7.*"},
{version="~0.21.0", python=">=3.8"},
]

Expand All @@ -49,7 +47,7 @@ numpy = "<=1.26.4"
isaura = {version="0.1", optional=true}
pytest = {version = "^7.4.0", optional = true}
fuzzywuzzy = {version = "^0.18.0", optional = true}
sphinx = {version = ">=5.3.0", optional = true} # For compatibility with python 3.7.x
sphinx = {version = ">=5.3.0", optional = true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we actually check which is the minimum version we need for 3.8?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure

jinja2 = {version = "^3.1.2", optional = true}
scipy = {version = "<=1.10.0", optional = true}

Expand Down