Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DEVELOPMENT.md file #1318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ajoke23
Copy link
Contributor

@Ajoke23 Ajoke23 commented Oct 11, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description
Currently, Ersilia doesn't have a DEVELOPMENT.md file in the repository. The main aim is to create a DEVELOPMENT.md instruction file

Changes to be made
Add a development .md file in ersilia repository

Status

  • Added a getting started section that highlight installation instruction, the use of GitHub codespace as an alternative method and the uses of running a model with verbose -v flag.
  • Added Ersilia Artifacts section which focuses on various artifacts that is found in the EOS directory within the user's $HOME path

To do
Add "Create a Pull Request" section

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1270

Added the getting started and Ersilia Artifacts session
@Ajoke23 Ajoke23 changed the title Create DEVELOPMENT.md Create DEVELOPMENT.md file Oct 11, 2024
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
ersilia -v fetch eos2ta5 #fetch a model
ersilia serve eos2ta5 #serve a model
ersilia -v api run -i "CCCC" #run a model
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can ask them to run the test suite as pytest -v

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DhanshreeA. I intend to add the run test suites in the "Creating of Pull Request" section.

DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated
- Open the terminal in codespace. To ensure you are in the root directory
`cd ersilia`
- Run this command
`pip install -e .`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't exactly need to do that I think, the environment is prepared with ersilia installed. But we should double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. ersilia is pre-installed and ready to use. To double check, i will add using ersilia --version in the documentation.
Thanks for the suggestion.

@Ajoke23
Copy link
Contributor Author

Ajoke23 commented Oct 13, 2024

Hi @DhanshreeA. Thanks for the suggestions. All necessary changes has been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants