Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with metacal psf method "gauss" #236

Merged
merged 4 commits into from
Oct 4, 2023
Merged

fix bug with metacal psf method "gauss" #236

merged 4 commits into from
Oct 4, 2023

Commits on Oct 3, 2023

  1. fix bug with metacal psf method "gauss" 

    The psf determination was being done on the pre pixel rather
than post pixel psf.  This required a Convolve with the
pixel afterward, which does not work as expected when the wcs
is complex

Added a metacal accuracy test as well
    @esheldon
    esheldon committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    fb1cd68 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. update test to include det_bands column

    @esheldon
    esheldon committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    4dbca02 View commit details
    Browse the repository at this point in the history

  2. satisfy the flake8 

    Note sure why this wasn't failing before
    @esheldon
    esheldon committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8f97869 View commit details
    Browse the repository at this point in the history

  3. update expected response test for fixed psf='gauss' metacal reconv me… 

    …thod
    @esheldon
    esheldon committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    45c2dc3 View commit details
    Browse the repository at this point in the history