Enable eqwalizer #70
Closed
Enable eqwalizer #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is tricky, but the result might actually be a cdata in the unlikely case
the cdata content matches some element name, like this:
<elem>elem</elem>
Check it like this:
> {ok, Elem} = exml:parse(<<"<elem>elem</elem>">>).
...
> exml_query:subelement(Elem, <<"elem">>, default).
#xmlcdata{content = <<"elem">>}
This is because #xmlel.name is just an index and both #xmlel{} and #xmlcdata{} records
do have a field with this index - it's just different fields.
So the spec should properly specify this function can technically return a cdata...
Or we can make sure it's a #xmlel{} by matching on Result.
erszcz
force-pushed
the
enable-eqwalizer
branch
from
f1147e8 to
52dc71b
Compare
erszcz
force-pushed
the
enable-eqwalizer
branch
from
52dc71b to
4bbb77a
Compare
|
Closing as parts of this PR were merged in #72 (commits were cherry-picked together with other ones). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables WhatsApp's eqWAlizer and fixes all errors it reports in exml. It's also intended as a tech spike to familiarise with eqwalizer and its capabilities.
All in all, the impression is very good - the typechecker is fast, reliable, easy to integrate with editor/IDE. Definitely recommended 👍
One shortcoming I found is that eqwalizer doesn't report redundant spec clauses. Dialyzer, however, seems to catch such cases if they're left after making a project eqwalizer clean, so the combo of both tools offers a comprehensive safety harness.
I'm creating this PR as a preview, not to force inclusion of eqwalizer in all our projects.