Check apps in an umbrella project #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luk-pau-es
force-pushed
the
umbrella-config
branch
from
d833587
to
135eab9
Compare
|
Hi @luk-pau-es, I've looked through this branch and it looks good to me for the most part -- I added some more changes on top of #124 since you branched off that MR, which I would like to be added here as well. I added all those changes in one commit on top of your branch, here: japhib@406c7f6 Mind cherry-picking it? |
…ing/disabling Gradient checks
…ing/disabling Gradient checks
…ing/disabling Gradient checks
luk-pau-es
force-pushed
the
umbrella-config
branch
from
6b08bc6
to
7e8886c
Compare
erszcz
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
It's great! Tremendous effort, @japhib and @luk-pau-es, making this happen in the first place and making sure both PRs finally converged 🎉🥳
|
Thanks for all your help @luk-pau-es @erszcz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on: #124
What was done:
Issue of the bug:
On file
lib/gradient.exwe call functionmaybe_specify_forms/2on line 46. Before that (line: 45) there is call to functionput_source_path/2. Bug cause was thatmaybe_specify_forms/2also called thisput_source_path/2which effectively aded source paths 2 times. I have verified thatmaybe_specify_forms/2is called only from that one specific location and removed redundant call toput_source_path/2from inside it.IMPORTANT
Right now the pipeline is all green but I need to investigate more about it as this is effect of re running failed jobs multiple times.