Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String only keys #110

Open
4 tasks
dan-online opened this issue Dec 14, 2022 · 1 comment
Open
4 tasks

String only keys #110

dan-online opened this issue Dec 14, 2022 · 1 comment

Comments

@dan-online
Copy link
Contributor

In regards to #104 and its ultimate reversion, the decision should be made on whether to make key, string only, or perhaps string | null, in order to provide a non-breaking version.

This will require the following

cc: @StrangeGirlMurph

@StrangeGirlMurph
Copy link
Contributor

My take: I prefer the current version. I mean everything else previously would have caused problems and lead to errors as well. Now the errors are just more consistent and there are better guidelines/insurances/whatever that ensure that it breaks at the right spot and people just have to take 4 mins to change the code to align with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants