Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add code coverage npm scripts #36

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: add code coverage npm scripts #36

merged 1 commit into from
May 31, 2024

Conversation

fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Add npm scripts to collect code coverage from tests. Run with npm run test:coverage in a package directory.

What changes did you make? (Give an overview)

  • Added a c8 config for the whole repo.
  • Added c8 dependency and test:coverage script to each package.json file.

Related Issues

Is there anything you'd like reviewers to focus on?

This should trigger a new release.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label May 30, 2024
@fasttime fasttime marked this pull request as ready for review May 30, 2024 21:19
@fasttime fasttime added the chore label May 30, 2024
@aladdin-add
Copy link
Member

should we also update the ci to run test:coverage

This should trigger a new release.

I don't think it's a bugfix, nor should it trigger a release. maybe ci or chore?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Switching to "chore" as this doesn't fix any bugs.

@nzakas nzakas merged commit 30a4306 into main May 31, 2024
14 checks passed
@nzakas nzakas deleted the add-c8 branch May 31, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants