Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of pacing_timer and simplify iperf_mt_send #1773

Merged

Conversation

davidBar-On
Copy link
Contributor

Removed the usage of pacing_timer, and keep it as a parameter for backward compatibility for servers running older versions of iperf3.

In addition, simplified iperf_send_mt(), since it contained some leftovers of the multi-streams support (including some variables renaming).

Tested with and without nanosleep support.

@bmah888
Copy link
Contributor

bmah888 commented Sep 25, 2024

Thanks for the PR! I like the idea of this change (haven't had a chance to really study it though).

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on all our supported platforms, pacing (still) works for both forward and reverse direction tests. I will merge this shortly. Thanks for making iperf3 smaller and (slightly) less complicated!

@bmah888 bmah888 merged commit 0586e1c into esnet:master Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants