feat(release): support for proper sentry release propagation VI

esnvutbrno · Nov 17, 2023 · 520a56a · 520a56a
1 parent a4bfe5d
commit 520a56a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -86,12 +86,12 @@ jobs:
           labels: ${{ steps.webMeta.outputs.labels }}
           build-args: |
             DJANGO_RELEASE_NAME: ${{ steps.meta.outputs.release_name }}
-            SENTRY_RELEASE_ENVIRONMENT: production
           secrets: |
             SENTRY_ORG=${{ secrets.SENTRY_ORG }}
             SENTRY_PROJECT=${{ secrets.SENTRY_PROJECT }}
             SENTRY_WEBPACK_AUTH_TOKEN=${{ secrets.SENTRY_WEBPACK_AUTH_TOKEN }}
             SENTRY_RELEASE_NAME=${{ steps.meta.outputs.release_name }}
+            SENTRY_RELEASE_ENVIRONMENT: production
 
       - name: Prepare image metadata
         id: proxyMeta
@@ -131,6 +131,7 @@ jobs:
             SENTRY_PROJECT=${{ secrets.SENTRY_PROJECT }}
             SENTRY_WEBPACK_AUTH_TOKEN=${{ secrets.SENTRY_WEBPACK_AUTH_TOKEN }}
             SENTRY_RELEASE_NAME=${{ steps.meta.outputs.release_name }}
+            SENTRY_RELEASE_ENVIRONMENT: production
 
   deploy:
     name: Deploy to cluster

diff --git a/Dockerfile b/Dockerfile
@@ -1,7 +1,3 @@
-# expected to be set during production release
-ARG SENTRY_RELEASE_ENVIRONMENT
-ARG DJANGO_RELASE_NAME
-
 #
 # webpack image
 #
@@ -41,9 +37,13 @@ RUN \
   --mount=type=secret,id=SENTRY_ORG \
   --mount=type=secret,id=SENTRY_PROJECT \
   --mount=type=secret,id=SENTRY_WEBPACK_AUTH_TOKEN \
+  --mount=type=secret,id=SENTRY_RELEASE_NAME \
+  --mount=type=secret,id=SENTRY_RELEASE_ENVIRONMENT \
   export SENTRY_ORG=$(cat /run/secrets/SENTRY_ORG) \
   export SENTRY_PROJECT=$(cat /run/secrets/SENTRY_PROJECT) \
   export SENTRY_WEBPACK_AUTH_TOKEN=$(cat /run/secrets/SENTRY_WEBPACK_AUTH_TOKEN) \
+  export SENTRY_RELEASE_NAME=$(cat /run/secrets/SENTRY_RELEASE_NAME) \
+  export SENTRY_RELEASE_ENVIRONMENT=$(cat /run/secrets/SENTRY_RELEASE_ENVIRONMENT) \
   && yarn build
 
 #