feat(accounts): for incoming editor and new section, promote him to a…

…dmin
esnvutbrno · Nov 15, 2023 · 52660a4 · 52660a4
1 parent c6d4953
commit 52660a4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/fiesta/apps/esnaccounts/provider.py b/fiesta/apps/esnaccounts/provider.py
@@ -67,7 +67,7 @@ def update_section_membership(
         user_nationality = sa.extra_data.get("nationality")
         # national_section = sa.extra_data.get("country")
 
-        section, _ = Section.objects.get_or_create(
+        section, is_section_new = Section.objects.get_or_create(
             name=section_name,
             defaults=dict(
                 code=section_code,
@@ -79,6 +79,9 @@ def update_section_membership(
 
         SectionPluginsReconciler.reconcile(section)
 
+        already_has_admin_user = section.memberships.filter(role=SectionMembership.Role.ADMIN).exists()
+        promote_editor_to_admin = not already_has_admin_user or is_section_new
+
         # role and activation only for first time
         SectionMembership.objects.get_or_create(
             user=user,
@@ -90,7 +93,7 @@ def update_section_membership(
                 state=SectionMembership.State.ACTIVE,
                 role=(
                     SectionMembership.Role.ADMIN
-                    if cls.ADMIN_ROLE in roles
+                    if cls.ADMIN_ROLE in roles or (promote_editor_to_admin and cls.EDITOR_ROLE in roles)
                     else (
                         SectionMembership.Role.EDITOR
                         if cls.EDITOR_ROLE in roles