fix(plugins): do not show menu item for editors

esnvutbrno · Nov 11, 2023 · cb51ce7 · cb51ce7
1 parent c7eadb9
commit cb51ce7
Showing 1 changed file with 27 additions and 18 deletions.
diff --git a/fiesta/apps/sections/apps.py b/fiesta/apps/sections/apps.py
@@ -37,24 +37,33 @@ def as_navigation_item(self, request: HttpRequest, bound_plugin: Plugin) -> Navi
             .as_navigation_item(request, bound_plugin)
             ._replace(
                 url="",
-                children=[
-                    NavigationItemSpec(
-                        _("Members"),
-                        reverse("sections:section-members"),
-                    ),
-                    NavigationItemSpec(
-                        _("Internationals"),
-                        reverse("sections:section-internationals"),
-                    ),
-                    NavigationItemSpec(
-                        _("Statistics"),
-                        reverse("sections:section-stats"),
-                    ),
-                    NavigationItemSpec(
-                        _("Plugins"),
-                        reverse("sections:section-plugins"),
-                    ),
-                ],
+                children=list(
+                    filter(
+                        None,
+                        [
+                            NavigationItemSpec(
+                                _("Members"),
+                                reverse("sections:section-members"),
+                            ),
+                            NavigationItemSpec(
+                                _("Internationals"),
+                                reverse("sections:section-internationals"),
+                            ),
+                            NavigationItemSpec(
+                                _("Statistics"),
+                                reverse("sections:section-stats"),
+                            ),
+                            (
+                                NavigationItemSpec(
+                                    _("Plugins"),
+                                    reverse("sections:section-plugins"),
+                                )
+                                if request.membership.is_section_admin
+                                else None
+                            ),
+                        ],
+                    )
+                ),
             )
         )