Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration does not honor the email.mention config key #386

Open
jgknight opened this issue Nov 23, 2014 · 3 comments · Fixed by #388
Open

Registration does not honor the email.mention config key #386

jgknight opened this issue Nov 23, 2014 · 3 comments · Fixed by #388
Labels

Comments

@jgknight
Copy link
Contributor

When setting the email.mention key = true, if a new user registers the "mention me in a post" setting by default is still disabled.

I think we just need to change config.defaults.php so that email.mention = false, and then in core/models/ETMemberModel.class.php line 60 update it so it contains

$preferences = array("email.privateAdd", "email.post", "starOnReply", "email.mention");

@jgknight jgknight added the Bug label Nov 23, 2014
jgknight added a commit to jgknight/esoTalk that referenced this issue Nov 24, 2014
This resolves esotalk#386 where despite email.mention config being set,
new users were not getting that preference set to true.
@inliquid
Copy link
Contributor

Strange - everything works fine w/o this fix...

@jgknight
Copy link
Contributor Author

jgknight commented Dec 2, 2014

When I tested without this fix it didn't work as expected. With the key set if I created a new user, they did not have the email.mention preference enabled by default. With this fix, if I had the key set and I created a user, the preference was correctly set by default.

I'll reopen so I can retest this.

@jgknight jgknight reopened this Dec 2, 2014
@inliquid
Copy link
Contributor

inliquid commented Dec 2, 2014

Ok, maybe I didn't get the case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants