Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement embassy_embedded_hal::SetConfig #1919

Closed
phemmer opened this issue Aug 11, 2024 · 1 comment · Fixed by #2477
Closed

Implement embassy_embedded_hal::SetConfig #1919

phemmer opened this issue Aug 11, 2024 · 1 comment · Fixed by #2477
Assignees
@bugadani
Milestone
0.22.0

Comments

@phemmer
Copy link

phemmer commented Aug 11, 2024 •
edited
Loading

This is a feature request to implement embassy_embedded_hal::SetConfig on anything which currently implements SpiBus (which would be Spi and SpiDma).

This would be useful with SpiDeviceWithConfig (blocking and async) for running multiple SPI devices with different clock speed capabilities on the same bus.

Yes, the user (me) could put a wrapper around Spi/SpiDma to implement SetConfig, and that might be what I do as a short term solution. But Just thought it would be good to have a native implementation.
@Dominaezzz
Copy link
Collaborator

Related #1666 and #1826

@MabezDev MabezDev added the status:needs-attention This should be prioritized label Oct 8, 2024
This was referenced Nov 2, 2024
Closed
Merged
Merged
Closed
@MabezDev MabezDev removed the status:needs-attention This should be prioritized label Nov 6, 2024
@MabezDev MabezDev added this to the 0.22.0 milestone Nov 6, 2024
@bugadani bugadani mentioned this issue Nov 7, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bugadani bugadani

Labels
None yet
Projects
esp-rs
Archived in project
Milestone
0.22.0
4 participants
@bugadani @phemmer @MabezDev @Dominaezzz