-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our time driver for upcoming embassy changes #2701
base: main
Are you sure you want to change the base?
Conversation
1f73ebd
to
3690f3b
Compare
64f0c56
to
bf8e06f
Compare
32ccce2
to
fa124d8
Compare
esp-hal-embassy/build.rs
Outdated
println!("cargo:rustc-check-cfg=cfg(single_queue)"); | ||
println!("cargo:rustc-check-cfg=cfg(generic_timers)"); | ||
|
||
match &crate_config["ESP_HAL_EMBASSY_TIMER_QUEUE"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out passing config options to tests for this. We should also figure out testing multiple feature sets, or configs in this case - otherwise we won't be exhaustive in our async tests. Although only the integrated timer is our implementation, it would be interesting to test the time driver's ability to provide multiple alarms, too.
554ca86
to
7eec7f7
Compare
7962435
to
1ffb55c
Compare
c1d406d
to
9a1c0cf
Compare
I'm rooting for you! 💪 |
This comment was marked as resolved.
This comment was marked as resolved.
f16ab0c
to
989595e
Compare
989595e
to
fefffe6
Compare
Update esp-hal-embassy for the new embassy-time-driver version.
We now manage our own timer queues, which means that
Configuration-wise, users have the options to select between:
ESP_HAL_EMBASSY_GENERIC_QUEUE_SIZE
I'm removing the trouble-host example with this PR because
What's needed: