-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa-test #2871
qa-test #2871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Also did some testing and now its way more convenient to test all the qa tests! Maybe we should thing if we require any other tag(s), maybe a tag for those qa-tests that dont require any extra-stuff is helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement, especially for sequentially running qa-tests. I'm not sure I see the purpose of the tag system, how do you plan to use this in the future? If it's only going to be used in qa-test
, which is all manual anyways, I don't think the tag system makes sense?
The tags are used to order the examples - i.e. when multiple examples require the same wiring (e.g. a SPI-flash chip) they use the same tag and the user doesn't need to rewire multiple times |
Ah I see, that makes sense! |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Closes #2566
We have the
qa-test
folder but running those tests was annoying and error-prone.While it was always possible to run
cargo xtask run-example FOLDER TARGET
(i.e. w/o the example name) it always gave an error.Now it will
Additionally, this introduces a new key
TAG
which is used to group the examples (i.e. multiple examples needing the same wiring should run after each other)In future we will move everything from examples over to qa-test (and adapt those examples to better serve as tests) but that is out of scope for this PR.
skip-changelog
since this isn't really worth mentioning thereTesting
See above