feat: add support for internal temperature sensor (tsens) for esp32c6 and esp32c3 #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davoclavo
force-pushed
the
feat/add_temp_sensor_support
branch
4 times, most recently
from
99cf766 to
d8eed8c
Compare
davoclavo
changed the title
davoclavo
force-pushed
the
feat/add_temp_sensor_support
branch
from
d8eed8c to
9e46483
Compare
davoclavo
commented
Jan 1, 2025
davoclavo
force-pushed
the
feat/add_temp_sensor_support
branch
2 times, most recently
from
0d6b2e7 to
5f033bf
Compare
MabezDev
requested changes
Jan 3, 2025
|
Thanks for the PR! Overall this a nice PR, and pretty close already - just a few bits to iron out. |
davoclavo
force-pushed
the
feat/add_temp_sensor_support
branch
4 times, most recently
from
4f36b6b to
0f0bd2e
Compare
|
Thanks a lot for the feedback. I have addressed all the suggested changes/improvements mentioned and rebased with the latest changes. About adding a HIL test: I tried to add a deterministic test to ensure the sensor is properly configured and working. Thought about making a test that tries to heat up the CPU and test there was an increase in temperature, but couldn't reliably heat it up in my experiments. |
bugadani
reviewed
Jan 6, 2025
- Also add misc derives to multiple structs - Add power_up / power_down methods to TemperatureSensor - Enable ApbSarAdc via PeripheralGuard
davoclavo
force-pushed
the
feat/add_temp_sensor_support
branch
from
0f0bd2e to
ad3e44b
Compare
|
Thanks a lot for the feedback! will keep it in mind, and looking forward to keep contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Added basic support for internal temperature sensor for esp32c6 and esp32c3. Starts paving the path to fix #2116
Next steps:
Testing
I created an example that measures internal chip temperature every second and prints it.
Any feedback is more than welcome, I'm very happy to start contributing to this amazing project!