Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp-wifi to match changes made to esp-hal #2889

Closed
wants to merge 3 commits into from

Conversation

MikeGstefan
Copy link

@MikeGstefan MikeGstefan commented Jan 4, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Changes to allow the development of projects using both esp-hal and esp-wifi

Bump version of embassy-sync to 0.6.1 to match the change to esp-hal made in (#2555) which prevented compilation of projects with both dependencies

Enabled the unstable feature on the esp-hal dependency introduced in (#2628) which is required for esp-wifi to compile

Testing

Projects which depend on upstream esp-hal can now compile

@bugadani
Copy link
Contributor

bugadani commented Jan 6, 2025

Thank you but we don't want to enable the unstable feature automatically. Doing so would mean that some users would be able to use unstable APIs without opting into them explicitly - and so they may not know the limitations and lack of guarantees on them.

We might want to look into stabilizing what esp-wifi needs in the near term, but for now the solution should be documenting that esp-wifi requires esp-hal/unstable.

@bugadani bugadani closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants