Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all feature sets #2901

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Test all feature sets #2901

merged 8 commits into from
Jan 9, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 7, 2025

Previously, when a test has multiple //% FEATURES: lines, only one was used. This PR assigns a name to each of those (failing if there are duplicates), and includes the name of the featureset in the resulting artifact.

Examples are placed into ./target/examples/CHIP/, tests are in ./target/tests/CHIP/

The PR no longer enables esp-hal/unstable unconditionally, giving us the option to create subsets in the HIL tests that only test the stable HAL.

This PR also hides interconnect so cc #2693

@bugadani bugadani added the skip-changelog No changelog modification needed label Jan 7, 2025
@bugadani bugadani marked this pull request as draft January 7, 2025 14:09
@bugadani bugadani marked this pull request as ready for review January 8, 2025 08:53
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing I discovered #2908 but it's unrelated.

LGTM

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Jan 9, 2025
Merged via the queue into esp-rs:main with commit 848029b Jan 9, 2025
28 checks passed
@bugadani bugadani deleted the gpio branch January 9, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants