Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peripheral instance types #2907

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove peripheral instance types #2907

merged 1 commit into from
Jan 9, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 8, 2025

Closes #2572

Skip-changelog applied because wifi/embassy previously spelled out AnyTimer.

@bugadani bugadani added the skip-changelog No changelog modification needed label Jan 8, 2025
@bugadani bugadani force-pushed the erase branch 4 times, most recently from a47cfde to 88ad4e3 Compare January 8, 2025 16:05
@bugadani bugadani marked this pull request as ready for review January 8, 2025 16:24
@bugadani
Copy link
Contributor Author

bugadani commented Jan 8, 2025

Ready but this is a merge conflict happy place so beware.

bjoernQ
bjoernQ approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MabezDev
MabezDev approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you rebase? Let's try and get this in before we get more conflicts 😅

@MabezDev MabezDev enabled auto-merge January 9, 2025 10:58
@MabezDev MabezDev added this pull request to the merge queue Jan 9, 2025
Merged via the queue into esp-rs:main with commit 0ef0020 Jan 9, 2025
28 checks passed
@bugadani bugadani deleted the erase branch January 9, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always type erase drivers
3 participants
@bugadani @bjoernQ @MabezDev