Fix thread-mode executor on core1 not waking up #2924
Merged
+62
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
executor
branch
2 times, most recently
from
3873c94 to
2d17ee3
Compare
Dominaezzz
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while testing #2701 - apparently this is an unrelated issue :) Bug was caused by
SoftwareInterrupt::set_interrupt_handlerwhich when called, disabled the interrupt handler on the "other" core. This meant that creating a handler on both cores ended up with only one of them handling the cross-core interrupt.Now the interrupt is registered once, then enabled on only the core(s) that need it.