ADC: Add async support for oneshot reads for esp32c3 and esp32c6 #2925
+332
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Add support for ADC async oneshot reads for esp32c3 and esp32c6. Fixes #1643
Testing
Added QA example that uses embassy executor and reads every second from GPIO5. I am able to measure distinct values just by handling the devkit board with my hands.
Extra notes
It seems the double oneshot read hack for esp32c6 is not required if interrupts are used. If someone is able to help me confirm this or figure out a way to replicate it I can work on adding that hack back.
Could someone help me out figuring out how could I alter my QA example to be able to perform concurrent reads to multiple channels using the same ADC interface, in order to address the potential issue that is currently solved by using the
active_channel
attribute for the blocking implementation, in order to implement some kind of synchronization mechanism for the async version.Should I add theDoneDm: crate::DriverMode
generic and only provide the Blocking implementation for the xtensa version of the Adc driver (and the esp32 Driver too) or leave it as is without the extra parameter?