Legalize C-QUESTION-MARK violation
#2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Jan 10, 2025
documentation/API-GUIDELINES.md
Outdated
| @@ -13,6 +13,7 @@ In general, the [Rust API Guidelines](https://rust-lang.github.io/api-guidelines | |||
| ## Amendments to the Rust API Guidelines | |||
|
|
|||
| - `C-RW-VALUE` and `C-SERDE` do not apply. | |||
| - `C-QUESTION-MARK`: `?` is not applicable in the context of the `main` function in our driver, documentation example makes no sense. | |||
There was a problem hiding this comment.
Suggested change
| - `C-QUESTION-MARK`: `?` is not applicable in the context of the `main` function in our driver, documentation example makes no sense. | |
| - `C-QUESTION-MARK`: `?` is not applicable in the context of the `main` function in our driver. |
Doc examples do make sense, just not with the question mark 🙃
bugadani
approved these changes
Jan 10, 2025
jessebraham
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #2811 (comment)