(cherry picked from commit 5b7be14)

(cherry picked from commit 8966207)

(cherry picked from commit 4c8b84a)

(cherry picked from commit 7c692e1)

…nikic"

This reverts commit 8c7a7e3, reversing
changes made to a00bd75.

(cherry picked from commit 472fef6)

(cherry picked from commit 12f2bcd)

See rust-lang#130634

(cherry picked from commit c3f9c4f)

…check_expr_struct_fields

(cherry picked from commit 95b9ecd)

…ency and we have a trait error

(cherry picked from commit 9d5d03b)

The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

    rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so

(cherry picked from commit de4c897)

(cherry picked from commit f46057b)

(cherry picked from commit 9cb540a)

(cherry picked from commit 9c91a4e)

(cherry picked from commit f0bfba2)

(cherry picked from commit e1c0f04)

(cherry picked from commit 7358429)

(cherry picked from commit 2f6307d)

(cherry picked from commit 0d94e6b)

(cherry picked from commit ebe4fc4)

LLVM does not include an implementation of the va_arg instruction for
Xtensa. From what I understand, this is a conscious decision and
instead language frontends are encouraged to implement it themselves.
The rationale seems to be that loading values correctly requires
language and ABI-specific knowledge that LLVM lacks.

This is true of most architectures, and rustc already provides
implementation for a number of them. This commit extends the support to
include Xtensa.

See https://lists.llvm.org/pipermail/llvm-dev/2017-August/116337.html
for some discussion on the topic.

Unfortunately there does not seem to be a reference document for the
semantics of the va_list and va_arg on Xtensa. The most reliable source
is the GCC implementation, which this commit tries to follow. Clang also
provides its own compatible implementation.

This was tested for all the types that rustc allows in variadics.

Co-authored-by: Brian Tarricone <brian@tarricone.org>

* Updates uses of object::Architecture within the compiler