Skip to content

Commit

Permalink
final review
Browse files Browse the repository at this point in the history
  • Loading branch information
@SuGlider
SuGlider committed Oct 5, 2023
1 parent ebb7f72 commit 493c347
Show file tree
Hide file tree
Showing 16 changed files with 12 additions and 54 deletions.
1 change: 0 additions & 1 deletion variants/XIAO_ESP32S3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x2886
#define USB_PID 0x0056
Expand Down
1 change: 0 additions & 1 deletion variants/atd147_s3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001
Expand Down
2 changes: 1 addition & 1 deletion variants/deneyapkart1A/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#include <stdint.h>
#include "soc/soc_caps.h"

static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+13;
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+13; //D12
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
Expand Down
2 changes: 1 addition & 1 deletion variants/deneyapkart1Av2/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#define USB_PRODUCT "DENEYAP KART 1A v2"
#define USB_SERIAL "" // Empty string for MAC adddress

static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+48;
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+48; //D9
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
Expand Down
2 changes: 1 addition & 1 deletion variants/deneyapkartg/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#define USB_PRODUCT "DENEYAP KART G"
#define USB_SERIAL "" // Empty string for MAC adddress

static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+10;
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+10; //D3
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
Expand Down
2 changes: 1 addition & 1 deletion variants/deneyapminiv2/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#define USB_PRODUCT "DENEYAP MINI v2"
#define USB_SERIAL "" // Empty string for MAC adddress

static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+33;
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+33; //D14
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
Expand Down
1 change: 0 additions & 1 deletion variants/esp32_s3r8n16/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001
Expand Down
4 changes: 2 additions & 2 deletions variants/gpy/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@

// Neopixel
#define PIN_NEOPIXEL 0 // ->2812 RGB !!!
static const uint8_t LED_BUILTIN = PIN_NEOPIXEL;
static const uint8_t LED_BUILTIN = PIN_NEOPIXEL + SOC_GPIO_PIN_COUNT;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
// RGB_BUILTIN and RGB_BRIGHTNESS can be used in new Arduino API neopixelWrite()
#define RGB_BUILTIN (PIN_NEOPIXEL + SOC_GPIO_PIN_COUNT)
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64

#define ANT_SELECT 21 // GPIO21 - WiFi external / internal antenna switch
Expand Down
9 changes: 2 additions & 7 deletions variants/heltec_wifi_kit_32_V3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,15 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define WIFI_Kit_32_V3 true
#define DISPLAY_HEIGHT 64
#define DISPLAY_WIDTH 128

#define PIN_NEOPIXEL 35
// BUILTIN_LED can be used in new Arduino API digitalWrite() like in Blink.ino
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+PIN_NEOPIXEL;
static const uint8_t LED_BUILTIN = 35;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
// RGB_BUILTIN and RGB_BRIGHTNESS can be used in new Arduino API neopixelWrite()
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64

static const uint8_t KEY_BUILTIN = 0;

static const uint8_t TX = 43;
Expand Down
1 change: 0 additions & 1 deletion variants/heltec_wifi_lora_32_V3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define WIFI_LoRa_32_V3 true
#define DISPLAY_HEIGHT 64
Expand Down
1 change: 0 additions & 1 deletion variants/lilygo_t_display_s3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001
Expand Down
10 changes: 1 addition & 9 deletions variants/m5stack_cores3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,11 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001

// Some boards have too low voltage on this pin (board design bug)
// Use different pin with 3V and connect with 48
// and change this setup for the chosen pin (for example 38)
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT + 48;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64
// CoreS3 has no builtin LED / NeoLED

static const uint8_t TX = 43;
static const uint8_t RX = 44;
Expand Down
1 change: 0 additions & 1 deletion variants/m5stack_stamp_s3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001
Expand Down
10 changes: 1 addition & 9 deletions variants/tamc_termod_s3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,11 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001

// Some boards have too low voltage on this pin (board design bug)
// Use different pin with 3V and connect with 48
// and change this setup for the chosen pin (for example 38)
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+48;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64
// This board has no NeoLED or any User LED

static const uint8_t TX = 43;
static const uint8_t RX = 44;
Expand Down
12 changes: 1 addition & 11 deletions variants/wifiduino32s3/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,11 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

#define USB_VID 0x303a
#define USB_PID 0x1001

// Some boards have too low voltage on this pin (board design bug)
// Use different pin with 3V and connect with 48
// and change this setup for the chosen pin (for example 38)
static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+48;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64
#define BOARD_HAS_NEOPIXEL
#define LED_BRIGHTNESS 64
// No USER LED or NeoLED

static const uint8_t TX = 45;
static const uint8_t RX = 44;
Expand Down
7 changes: 1 addition & 6 deletions variants/wifiduinov2/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,10 @@
#define Pins_Arduino_h

#include <stdint.h>
#include "soc/soc_caps.h"

static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT+13;
static const uint8_t LED_BUILTIN = 13;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
#define RGB_BUILTIN LED_BUILTIN
#define RGB_BRIGHTNESS 64
#define BOARD_HAS_NEOPIXEL
#define LED_BRIGHTNESS 64

static const uint8_t TX = 21;
static const uint8_t RX = 20;
Expand Down

0 comments on commit 493c347

Please sign in to comment.