Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard crypto parts in "Update" to save resources #10629

Closed
wants to merge 119 commits into from

Conversation

Jason2866
Copy link
Collaborator

This PR guards the crypto parts in library Update.
By doing this flash space is saved, since most users don't use crypto updates. To enable the possibility of crypto updates again just adding #define UPDATE_CRYPT to the sketch to enable the functionality again.
(similar to #9893)

me-no-dev and others added 30 commits August 19, 2024 23:28
Required to start compilation. Board is currently hidden and many options are removed
* fix(uart): sleep retention

sets new flag from IDF 5.3 that causes error with Serial.begin(115200).

* fix(typo): typo and commentaries

* feat(uart): adds memset to make structure empty

* fix(uart): missing parentesis - typo

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* IDF release/v5.3 2c46030b

* IDF release/v5.3 cc3203dc

* IDF release/v5.3 4d0db704
* feat(esp32p4): Initial changes required for ESP32-P4

* esp32-p4: Initial changes to build with Arduino

Signed-off-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>

* fix(esp32p4): Fix lib builder errors

* change(esp32p4): Unhide board

* ci(esp32p4): Add ESP32-P4 to workflow

* change(esptool): Update esptool to 4.8.0

* fix(build): Fix redefinition errors

* fix(build): Remove old commands

* change(esptool): Remove unsupported 32-bit tools

* fix(get.py): Force exe generation

* Revert "fix(get.py): Force exe generation"

This reverts commit 979b16b.

* fix(get.py): Fix system check

* change(tools): Push generated binaries to PR

* ci(esp32p4): Add missing ESP32-P4 entries

* fix(esp32p4): Add chip info

* fix(esp32p4): Fix build commands

* docs(esp32p4): Add missing references to P4

* fix(esp32p4): Fix clock sources definitions

* fix(esp32p4): Set CPU frequency to 360 MHz so it is stable in all chips

* refactor(esp32p4): Change preprocessor conditionals for maintainability

Co-authored-by: me-no-dev <hristo@espressif.com>

* fix(esp32p4): Add missing menu options

* fix(esp32p4): Mark as not in development json in readme

* fix(esp32p4): Add P4 to ci.json files

* ci(pre-commit): Apply automatic fixes

* fix(get.py): Remove unused include

* ci(pre-commit): Apply automatic fixes

* change(tools): Push generated binaries to PR

* ci(pre-commit): Apply automatic fixes

* fix(ci.json): Fix formatting

---------

Signed-off-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Jason2866 <24528715+Jason2866@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: me-no-dev <hristo@espressif.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(esp32p4): Add missing touchpad definitions

* fix(esp32p4): Add missing target in SPI example

* fix(esp32p4): Start touch driver fix

* fix(esp32p4): Skip touch examples while it is not implemented

* fix(esp32p4): Add missing analog pin definitions

* refactor(formatting): Fix formatting that was broken in P4 PR

* fix(openthread): Add missing targets to skip

* fix(esp32p4): Skip ethernet sketches

* fix(esp32p4): Disable periman test while touch is not implemented

* fix(esp32p4): Disable touch test while touch is not implemented

* fix(esp32p4): Fix UART test

* fix(esp32p4): Skip Wi-Fi test

* fix(esp32): Skip unsupported example

* fix(esp32p4): Fix skip files

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
lucasssvaz and others added 28 commits November 4, 2024 19:43
* IPv6 restore zone id

This PR restores the IPv6 zone-id in String representation of IPv6 address as well as parsing. This follows espressif@20a28b5 that disabled it due to a crash in `netif_index_to_name()`.

The fixed code scans through `netif_list` to find the `netif` name and id.

Note: zone-id are incremented by 1 compared to `netif` id.

For example internal zoneid value `3` actually translates to `%st2`

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(matter): source code folder organization

* feat(matter): new matter endpoint dimmable light

* feat(matter): dimmable friend class and adjusts log levels

* feat(matter): adds new folder and source code to cmakelists.txt

* fix(matter): identation in cmakelists.txt

* feat(matter): adds license disclaimer to all source code

* feat(matter): example code simplification

* feat(matter): make it work with rgb and analog led

* feat(matter): single user callback based on lambda function

* feat(matter): commentaries and code improvement. update() and callbacks added.

* feat(matter): adde new keywords to arduino settings

* feat(matter): example code adjustment to use improved api

* fix(matter): it shuold work even when no callback is set

* feat(matter): matter.h includes all possible endpoint header files

* feat(matter): adjusts all examples to only include matter.h

* fix(matter): double declaration of ret - var scope issue

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
)

* fix(wifi): Fix requirements and guards for hosted Wi-Fi

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* fix(net): Allow to compile without IPv6 enabled

cc: @Jason2866

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ssif#10597)

* fix(build): Allow Arduino to compile in IDF without components

This adds guards for the rest of the extra components

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(zigbee): Bump zigbee version and use 1.6.0 (espressif#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* fix(zigbee): Fix removed cluster_role attribute (espressif#10576)

* fix(hosted): Update hosted configuration

* fix(hosted): Fix Hosted deinit and protect reinit for now

* IDF release/v5.3 a0f798cf

* IDF release/v5.3 a0f798cf

---------

Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* fix formatting

* Disable formatter for these lines

---------

Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* feat(matter): adjust preferences labels in matter examples

* feat(matter): adjust preferences labels in matter examples

* fix(matter_example): extra blank space in code added by mistake

* feat(matter_example): use const char * instead of #define

* feat(matter_example): use const char * instead of #define

* feat(matter_example): change Preferences names

* fix(matter_example): missing semicolon in code
…0619)

* feat(uart): adds Serial4 as a keyword - used by ESP32-P4

* fix(keywords): added 2 new lines to keep consistancy
)

* Update ETH.cpp

* Update ETH.h

* Update WiFiGeneric.h

* Update NetworkEvents.h

* remove unnecessary include "sdkconfig.h"

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* Guard WPA Enterprise support

* guard `WIFI_ENTERPRISE_SUPPORT`

* wrong part guarded

* fix guard start and end

* add guard enterprise
* fix(Zigbee): Add missing direction to report commands

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…#10626)

* feat(zigbee): Add setLight APIs to manually operate lights

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@Jason2866 Jason2866 closed this Nov 20, 2024
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add P4 to chip info":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add RMII Ethernet support for ESP32-P4 (#10479)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add support for WiFi to ESP32-P4 (#10463)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "ESP32-P4 UART Pin Definitions (#10521)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Enable tests for ESP32P4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix build of camera web server":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix ethernet examples JSON for P4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix formatting in ETH and USB":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix partitions for examples":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix touch examples JSON for P4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Guard WPA Enterprise support (#10616)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Guard ethernet parts to make it possible to use without (#10609)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10272)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10403)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10444)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10465)":
    • footer's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10503)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10599)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 0bbd7281 (#10258)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 59550599 (#10498)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 707d097b (#10416)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 707d097b (#10473)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 707d097b (#10480)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 a0f798cf (#10522)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Matter example patch (#10618)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update MatterOnOffLight.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update TinyUSB init method":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Updater.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.1.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update early system init function declaration":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esp-insights version (#10456)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package_esp32_index.template.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update readme":
    • summary looks empty
    • type/action looks empty
  • the commit message "add(build): Add initial ESP32-P4 skeleton":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "feat(Matter): New Matter Endpoint - Dimmable Light (#10543)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feature(rtos): Add Tasks status print function (#10515)":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "fix weird formatting, no code change (#10617)":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(IPaddress): IPv6 restore zone id (#10546)":
    • body's lines must not be longer than 100 characters
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(Zigbee): Add missing direction to report commands (#10623)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(bm): Board Manager install will fail on Windows (#10533)":
    • body's lines must not be longer than 100 characters
  • the commit message "fix(build): Fix many warnings":
    • summary looks too short
  • the commit message "fix(build): Fix warning in FFat":
    • summary looks too short
  • the commit message "fix(eth): Set default clock in pin value to zero (#10513)":
    • body's lines must not be longer than 100 characters
  • the commit message "fix(p4): Move ESP-HOSTED init to WiFiGeneric":
    • body's lines must not be longer than 100 characters
  • the commit message "fix(spiram): Fix OPI PSRAM init":
    • summary looks too short
  • the commit message "guard crypt update":
    • summary looks empty
    • type/action looks empty
  • the commit message "guard update crypt":
    • summary looks empty
    • type/action looks empty
  • the commit message "replace outdated wrong SOC_I2C_NUMand useSOC_HP_I2C_NUM (#10452)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 119 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 5943), you might consider splitting it into smaller PRs

👋 Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f92abd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants